20 Oct
2025
20 Oct
'25
8:56 p.m.
On Mon Oct 20 20:56:40 2025 +0000, Rémi Bernon wrote:
Sorry to have missed that. Fwiw I think the lock (and probably a different one, there's no need to lock the fd cache) should be taken again within `cache_inproc_sync` but only for the things where it's actually necessary. It does rather costly calls, like `mmap` and there's things like `InterlockedCompareExchangePointer` in it which are rather pointless otherwise. Nvm, I guess the entire sync retrieval and caching needs to be atomic. Anyway, still I think the compare exchange looks confusing if it always happens inside a lock.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9234#note_119098