Re: [PATCH v5 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/shlwapi/tests/url.c:
> for (i = 0; i < ARRAYSIZE(TEST_URL_UNESCAPEW); i++)
>      {
> +        if (TEST_URL_UNESCAPEW[i].flags | URL_UNESCAPE_AS_UTF8
> +                && !!strcmp(winetest_platform, "wine")
> +                && !is_win8_plus())

Please don't do checks like that. You may just call `UrlUnescapeW` with a simple UTF8 test case before entering the loop and if it's broken, print `win_skip` and skip UTF8 tests in the loop.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/585#note_41331