16 Oct
2023
16 Oct
'23
7:06 p.m.
On Mon Oct 16 16:56:35 2023 +0000, André Zwing wrote:
My understanding is that the relocations should be done if (module != NtCurrentTeb()->Peb->ImageBaseAddress). But it currently returns early in that case. I had some issues with your change in Hangover, got a c0000018 and the application to be emulated didn't load. So after checking why, I found your commit and thought the logic should be inverted. You indicate that's wrong, so it seems I miss something. Relocations need to be done for the main exe, so for module == NtCurrentTeb()->Peb->ImageBaseAddress. Other exe modules are not relocated.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4103#note_48833