22 Jan
2024
22 Jan
'24
4:25 p.m.
Esme Povirk (@madewokherd) commented about dlls/shell32/shlfileop.c:
+ if (!(ops->flags & FOF_NOCONFIRMATION) && !PathFileExistsW(folder)) + { + if (!SHELL_ConfirmDialogW(ops->hwnd, ASK_CREATE_FOLDER, PathFindFileNameW(folder), NULL)) + { + ops->fAnyOperationsAborted = TRUE; + return ERROR_CANCELLED; + } + ret = SHNotifyCreateDirectoryW(folder, NULL); + if (S_OK != ret) return ret; + } + + PathCombineW(path, folder, name); + + if (attributes & FILE_ATTRIBUTE_DIRECTORY) + { + ret = SHNotifyCreateDirectoryW(path, NULL); `SHNotifyCreateDirectory` returns a win32 error code, not an HRESULT.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4817#note_58415