18 Dec
2024
18 Dec
'24
9:19 a.m.
Jacek Caban (@jacek) commented about libs/capstone/include/capstone/platform.h:
// handle C99 issue (for pre-2013 VisualStudio) -#if !defined(__CYGWIN__) && !defined(__MINGW32__) && !defined(__MINGW64__) && (defined (WIN32) || defined (WIN64) || defined (_WIN32) || defined (_WIN64)) +#if !defined(__GNUC__) \ + && !defined(__CYGWIN__) && !defined(__MINGW32__) && !defined(__MINGW64__) && (defined (WIN32) || defined (WIN64) || defined (_WIN32) || defined (_WIN64))
All those checks seem needlessly complicated. If we need a local diff anyway, we could just unconditionally include `stdbool.h`. For upstream capstone, I guess it could be just `defined(_MSC_VER)`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7040#note_90792