1 Mar
2023
1 Mar
'23
12:26 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
return reservation; }
+static struct hlsl_reg_reservation parse_packoffset(struct hlsl_ctx *ctx, const char *reg_string, + const char *swizzle, const struct vkd3d_shader_location *loc) +{ + struct hlsl_reg_reservation reservation = {0}; + + if (!sscanf(reg_string + 1, "%u", &reservation.index))
This is incorrectly accepted: ``` cbuffer buffer { float4 a : packoffset(c1ha_ha_I_shouldnt_be_here_but_sscanf_just_doesnt_care); float4 b : packoffset(c2); } float4 main() : sv_target { return 100 * a + b; } ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106#note_25876