22 May
2025
22 May
'25
10:02 a.m.
Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/video_frame_sink.c:
video_frame_sink_set_flag(sink, FLAGS_FIRST_FRAME, FALSE); }
- if (state == SINK_STATE_RUNNING && sink->state != SINK_STATE_RUNNING) + if (state == SINK_STATE_RUNNING && (sink->state != SINK_STATE_RUNNING || offset != PRESENTATION_CURRENT_POSITION)) video_frame_sink_stream_request_sample(sink);
I understand it probably can't happen in practice, but could we extend this check to say "paused && offset != current_position", to make it clear which state we are transitioning from. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7932#note_104194