28 Feb
2024
28 Feb
'24
2:57 p.m.
On Wed Feb 28 11:16:56 2024 +0000, Stefan Dösinger wrote:
I am wondering if this breaks the tests (test_create_device_from_clipper1 checks the refcount), but the IDirectDrawSurface::SetClipper holds a reference itself. So we're probably fine with not holding a ref ourselves, especially if we don't use the clipper object anywhere. FWIW, I ran the tests on a local box running XP bare-metal, and it seemed fine with this.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5161#note_62935