On Wed Nov 6 10:02:22 2024 +0000, Zhiyi Zhang wrote:
``` wintypes:propertyset propertyset.c:497 Test succeeded inside todo block: expected map to have key L"Boolean" wintypes:propertyset propertyset.c:497 Test succeeded inside todo block: expected map to have key L"UInt16" wintypes:propertyset propertyset.c:497 Test succeeded inside todo block: expected map to have key L"Int16" wintypes:propertyset propertyset.c:497 Test succeeded inside todo block: expected map to have key L"UInt32" wintypes:propertyset propertyset.c:497 Test succeeded inside todo block: expected map to have key L"Int32" wintypes:propertyset propertyset.c:497 Test succeeded inside todo block: expected map to have key L"Single" ``` You need to remove todo_wine for these tests that succeed after implementation. Otherwise, CI will report failures.
This was due to `HasKey` not setting `replaced` to 0, just returning `E_NOTIMPL`. Should be fixed now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_86740