28 Jul
2022
28 Jul
'22
9:02 p.m.
Nikolay Sivov (@nsivov) commented about dlls/mf/sar.c:
}
IMFMediaType_DeleteItem(renderer->media_type, &MF_MT_AUDIO_PREFER_WAVEFORMATEX); + IMFMediaType_DeleteItem(renderer->media_type, &MF_MT_AUDIO_VALID_BITS_PER_SAMPLE); + IMFMediaType_DeleteItem(renderer->media_type, &MF_MT_AUDIO_CHANNEL_MASK);
Same here regarding the tests, verifying that what we remove is actually meant to be missing. As I recall renderer returns several possible types on Windows, including spatial one. We don't currently, but it's possible MFInitMediaTypeFromWaveFormatEx() was an overkill and we only need to set a few attributes instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/553#note_5289