Re: [PATCH v4 0/1] MR1414: ntdll: Add integration with Linux FAT file attributes

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/file.c:
> return STATUS_SUCCESS;
>  }
>
> +#ifdef HAVE_LINUX_MSDOS_FS_H
> +static BOOL get_fat_dos_attrib( const char *path, ULONG *attr )
> +{
> +    BOOL ret = FALSE;
> +    int fd = open( path, O_PATH );
> +
> +    if (fd)
> +    {
> +        if (fd_get_fat_dos_attrib( fd, attr )) ret = TRUE;
> +        close( fd );
> +    }

This isn't going to work, FAT_IOCTL_GET_ATTRIBUTES needs a real fd with read access.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1414#note_18131