Re: [PATCH 0/2] MR8920: cmd: Fix some TYPE command behavior (one more try).

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/cmd/builtins.c:
> -		FILE_ATTRIBUTE_NORMAL, NULL);
> -    if (h == INVALID_HANDLE_VALUE) {
> +    hIn = CreateFileW(thisArg, GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, NULL, OPEN_EXISTING,
> +            FILE_ATTRIBUTE_NORMAL, NULL);
> +    if (hIn == INVALID_HANDLE_VALUE) {
>        WCMD_print_error ();
>        WCMD_output_stderr(WCMD_LoadMessage(WCMD_READFAIL), thisArg);
>        return errorlevel = ERROR_INVALID_FUNCTION;
> -    } else {
> -      if (writeHeaders) {
> -        WCMD_output_stderr(L"\n%1\n\n\n", thisArg);
> -      }
> -      while (WCMD_ReadFile(h, buffer, ARRAY_SIZE(buffer) - 1, &count)) {
> +    }
> +    hOut = GetStdHandle(STD_OUTPUT_HANDLE);
> +    if (hOut == INVALID_HANDLE_VALUE) {
> that block about hOut isn't needed (validation of output file when redirecting has already been done)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8920#note_115186