Re: [PATCH v5 0/10] MR7779: mshtml: Misc prototype fixes.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/htmlwindow.c:
> HTMLElement *elem;
>      HRESULT hres;
>
> -    if(dispex_compat_mode(dispex) >= COMPAT_MODE_IE9) {
> +    if(compat_mode >= COMPAT_MODE_IE9) {
>          const WCHAR **constr_name = bsearch(&name, constructor_names, ARRAYSIZE(constructor_names) ,
>                                              sizeof(constructor_names[0]), cmp_name);
> -        if(constr_name) {
> -            prototype_id_t id = constr_name - constructor_names + 1;
> -            compat_mode_t compat_mode = dispex_compat_mode(dispex);
> +        prototype_id_t id = 0;
> +
> +        if(constr_name)
> +            id = constr_name - constructor_names + 1;
> +        else if(!wcscmp(name, L"Image"))
> +            id = CTOR_HTMLImageElementFactory;

This looks very ad-hoc. I created !7852 with an alternative version and various other clean ups.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7779#note_101391