On Wed Dec 10 20:54:37 2025 +0000, Nikolay Sivov wrote:
Is it possible to consolidate those checks in mmdevapi, and not duplicating them for each driver? The driver-specific checks are different for each driver, and they depend on values computed in driver-specific code, so I see no way of consolidating them in the same place. There is probably room for making all drivers share more code (and that's likely to be a good thing to do), but that's a much bigger thing which I'm not planning to do, and that doesn't look appropriate for code freeze. Here I'm trying to keep the changes focused on fixing a specific crash.
One the freeze is over I plan to upstream more code dealing with validating the wave format data, which we currently a bit differently from Windows and that shows in some applications. But that's not specifically focused on preventing crashes nor sharing code between drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9749#note_125411