2 Oct
2023
2 Oct
'23
2:17 p.m.
Giovanni Mascellani (@giomasce) commented about tests/shader_runner_d3d12.c:
size_t i;
cs_code = compile_shader(runner, runner->r.cs_source, SHADER_TYPE_CS); - todo_if (runner->r.is_todo) ok(cs_code, "Failed to compile shader.\n"); + todo_if (runner->r.is_todo && runner->r.minimum_shader_model < SHADER_MODEL_6_0) ok(cs_code, "Failed to compile shader.\n");
Minor, but I would be in favor or removing the after `todo_if`, like we do for any other macro and function invocation. It happens below too. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346#note_47371