18 Jul
2023
18 Jul
'23
9:11 a.m.
Jacek Caban (@jacek) commented about dlls/jscript/set.c:
{ - FIXME("\n"); - return E_NOTIMPL; + struct weakmap_entry *entry, *entry2; + WeakMapInstance *weakmap; + HRESULT hres; + + hres = get_weakmap_this(ctx, vthis, &weakmap); + if(FAILED(hres)) + return hres; + + TRACE("%p\n", weakmap); + + RB_FOR_EACH_ENTRY_DESTRUCTOR(entry, entry2, &weakmap->map, struct weakmap_entry, entry) + release_weakmap_entry(entry); + rb_destroy(&weakmap->map, NULL, NULL); It's redundant after removing all entries.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3300#note_39265