24 Oct
2022
24 Oct
'22
11:52 a.m.
Huw Davies (@huw) commented about dlls/win32u/font.c:
static void set_multi_value_key( HKEY hkey, const WCHAR *name, const char *value, DWORD len ) { - WCHAR valueW[256]; + WCHAR *valueW; + + if (!(valueW = malloc( len * sizeof(WCHAR) ))) { + ERR("malloc of %d * WCHAR failed\n", len); + return; + } ascii_to_unicode( valueW, value, len ); if (value) set_reg_value( hkey, name, REG_MULTI_SZ, valueW, len * sizeof(WCHAR) ); else if (name) reg_delete_value( hkey, name ); + free(valueW);
```suggestion:-0+0 free( valueW ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1147#note_11873