Re: [PATCH v7 0/4] MR3319: evr: Leave critical section before waiting for streaming thread.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/evr/sample.c:
> -
> -    if (allocator->callback)
> -        IMFVideoSampleAllocatorNotify_NotifyRelease(allocator->callback);
> -
> +    callback = allocator->callback;
> +    if (callback && allocator->lock_notify_release)
> +    {
> +        IMFVideoSampleAllocatorNotify_NotifyRelease(callback);
> +        callback = NULL;
> +    }
>      LeaveCriticalSection(&allocator->cs);
>
> +    if (callback)
> +        IMFVideoSampleAllocatorNotify_NotifyRelease(callback);
> +
>      return S_OK;
> Now there is a chance that "callback" itself is released before you get to NotifyRelease().

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_41945