Re: [PATCH 0/3] MR1199: Implement a few APIs

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> +        return MX_E_ENCODING;
> +    case XmlWriterState_ElemStarted:
> +	writer_close_starttag(This);
> +	break;
> +    case XmlWriterState_Ready:
> +    case XmlWriterState_DocClosed:
> +        This->state = XmlWriterState_DocClosed;
> +        return WR_E_INVALIDACTION;
> +    default:
> +        ;
> +    }
> +
> +    This->textnode = 1;
> +    not_written = write_escaped_string(This, pwch, cwch);
> +    if (not_written)
> +       return WC_E_XMLCHARACTER;
> I think this is misleading. Not written does not imply "invalid character" condition.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1199#note_12650