Re: [PATCH 0/7] MR5666: d3dx9: Introduce d3dx_resource structures for use in code sharing.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/volume.c:
> return hr;
>  }
>
> +static void set_d3dbox(D3DBOX *box, uint32_t left, uint32_t top, uint32_t right, uint32_t bottom, uint32_t front,
> +        uint32_t back)
> +{
> +    box->Left = left;
> +    box->Top = top;
> +    box->Right = right;
> +    box->Bottom = bottom;
> +    box->Front = front;
> +    box->Back = back;
> +}

Right. I think it would be nice to have this (or the same on an equivalent, private, struct) in the generic helpers.

FWIW, the name `set_d3dbox()` looks fine here, because the function works on a simple, small structure that you wouldn't necessarily expect to be initialized only once.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5666#note_71131