21 Jun
2024
21 Jun
'24
2:01 p.m.
Huw Davies (@huw) commented about dlls/mmdevapi/client.c:
- return E_NOTIMPL; + UINT32 dummy; + HRESULT hr; + + TRACE("(%p)->(%p, %p)\n", This, cur_format, cur_period_frames); + + if (!cur_format || !cur_period_frames) + return E_POINTER; + + if (FAILED(hr = client_GetMixFormat(iface, cur_format))) + return hr; + + if (FAILED(hr = client_GetSharedModeEnginePeriod(iface, *cur_format, cur_period_frames, &dummy, &dummy, &dummy))) + return hr; + + return hr; Any reason not to return directly from `client_GetSharedModeEnginePeriod()`?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5875#note_73925