Re: [PATCH 0/1] MR2263: evr: Fix crash when clear input type for the mixer

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/evr/mixer.c:
> TRACE("%p, %lu, %p, %#lx.\n", iface, id, media_type, flags);
>
> +    if (!media_type && (flags & MFT_SET_TYPE_TEST_ONLY))
> +        return E_INVALIDARG;
> +
>      EnterCriticalSection(&mixer->cs);
>
> if (!(flags & MFT_SET_TYPE_TEST_ONLY))
>          video_mixer_clear_types(mixer);
>
> -    if (!mixer->device_manager)
> +    if (!media_type)
> +        hr = S_OK;
> +    else if (!mixer->device_manager)
>          hr = MF_E_NOT_INITIALIZED;
>      else

I don't see a test for that - what should be checked first, initialization status or null input pointer.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2263#note_25263