6 Feb
2025
6 Feb
'25
9 a.m.
On Tue Feb 4 14:24:58 2025 +0000, Jacek Caban wrote:
In case of error, we'd leak previously converted strings, so cleanup code path should probably also iterate `str_array` and free them. We could move `SysFreeString` call to the cleanup part and have a separate loop there. With more code in the cleanup path, it would be tempting to share more with the success path: you could free everything first and then either return `hres` or `return_bstr` depending on `hres` variable. Applied. Kept my commits unsquashed so it' simpler to see the changes. Will squash once everything is ok.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_93842