28 Apr
2023
28 Apr
'23
3:23 p.m.
Rémi Bernon (@rbernon) commented about dlls/winewayland.drv/wayland.c:
struct wayland *process_wayland = NULL; BOOL process_wayland_initialized = FALSE;
+static void wayland_mutex_init(pthread_mutex_t *mutex, int type) +{ + pthread_mutexattr_t mutexattr; + pthread_mutexattr_init(&mutexattr); + pthread_mutexattr_settype(&mutexattr, type); + pthread_mutex_init(mutex, &mutexattr); + pthread_mutexattr_destroy(&mutexattr); +} The helper doesn't seem to add much value, as you use normal mutexes. We use pthread_mutex_init directly in other places, with direct pthread_mutexattr_settype calls for some very rare recursive mutexes.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2712#note_31525