On Sat Feb 14 09:03:08 2026 +0000, Rémi Bernon wrote:
Should we check for GL_ARB_multisample as the winemac driver does? This could be done in init_device_info maybe, where we create contexts (it needs to check that the initialized device is the display device one). Well, I am struggling to find it specified entirely clearly, but I think those are different things. WGL_ARB_multisample is a WSI thing, it is responsible for supporting corresponding visual / pixel format queries (e. g., WGL_SAMPLES_ARB pixel format attrib). On GLX there is direct equivalent GLX_ARB_multisample (giving, e. g., GLX_SAMPLES_ARB). It looks like on EGL those are supported unconditionally (like EGL_SAMPLES_ARB) and that what Wine does. Then, GL_ARB_multisample is GL rendering driver extension, allowing using multisampling in GL rendering commands. So I think there is no equivalent. So it seems to me that from format correctness standpoint we don't have reasons to disable WGL_ARB_multisample even if GL_ARB_multisample is somehow not avaialable.
This distinction also makes it not entirely straightforward: GL_ one are specific for device while WGL_ extensions are not. So maybe we can keep it straightforward and simpler in this case and just enable WGL_ARB_multisample, as we enable unconditionally the functionality under exactly this? Note that if the extension is supported, it doesn't mean that multisample is supported: the system may in theory still not be giving any multisampled visual configs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10103#note_129695