15 Sep
2022
15 Sep
'22
8:20 a.m.
Huw Davies (@huw) commented about dlls/winecoreaudio.drv/mmdevdrv.c:
This->parent = dev; IMMDevice_AddRef(This->parent);
- This->dev_id = dev_id; + snprintf(This->dev_name, sizeof(This->dev_name), "%lu", dev_id);
There shouldn't be a need for this. The device name string should be opaque to the client. What you should do is change `get_deviceid_by_guid()` to return the device name rather than the device id (and rename it to something like `get_device_by_guid()`). Again, see the alsa driver. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/813#note_8494