Re: [PATCH v5 0/6] MR2091: windows.media.speech: Initial Unixlib work.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/vosk.c:
> +    return status;
> +}
> +
> +static NTSTATUS vosk_create( void *args )
> +{
> +    struct vosk_create_params *params = args;
> +    char locale[LOCALE_NAME_MAX_LENGTH];
> +    VoskRecognizer *recognizer = NULL;
> +    VoskModel *model = NULL;
> +    NTSTATUS status;
> +
> +    TRACE("args %p.\n", args);
> +
> +    if(!ntdll_wcstoumbs(params->locale, params->locale_len, locale, LOCALE_NAME_MAX_LENGTH, FALSE))
> +        return STATUS_UNSUCCESSFUL;
> +
> You're missing a space here, also wouldn't it be easier to do the WtoA conversion on the PE side? You could also convert it to lowercase there as well with `CharLowerW`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2091#note_23213