Re: [PATCH v9 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.

[Connor McAdams (＠cmcadams)]

Connor McAdams (@cmcadams) commented about dlls/setupapi/tests/devinst.c:
> +    ok(ret, "Failed to create device, error %#lx.\n", GetLastError());
> +
> +    for (i = 0; i < ARRAY_SIZE(reg_props); i++)
> +    {
> +        const struct reg_property *prop = ®_props[i];
> +        BOOL todo = prop->reg_prop != SPDRP_CLASSGUID;
> +        DWORD size = 0, type = 0;
> +        DEVPROPKEY key = { DEVPKEY_Device_DeviceDesc.fmtid, prop->reg_prop + 2 };
> +        BYTE buf[80] = { 0 };
> +
> +        winetest_push_context("reg_props[%lu] (%#lx)", i, prop->reg_prop);
> +        SetLastError(0xdeadbeef);
> +        ret = pSetupDiSetDevicePropertyW(set, &device_data, &key, prop->devprop_type, prop->devprop_value,
> +                                         prop->devprop_size, 0);
> +        err = GetLastError();
> +        ok(ret, "Failed to set property, error %#lx.\n", err);
        ok(ret, "Expect success.\n");

Not a _big_ deal, but since you're already printing the error on the next line, no need to double print it here as well.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109603