4 Nov
2025
4 Nov
'25
6:31 p.m.
Rémi Bernon (@rbernon) commented about dlls/dmusic/instrument.c:
} }
+ while (!list_empty(&This->downloaded_waves)) + { + downloaded_wave = LIST_ENTRY(list_head(&This->downloaded_waves), struct downloaded_wave, entry);
It's usually done like this instead, or with LIST_FOR_EACH_ENTRY_SAFE: ```suggestion:-2+0 struct list *ptr; /* ... */ while ((ptr = list_head(&This->downloaded_waves)) { downloaded_wave = LIST_ENTRY(ptr, struct downloaded_wave, entry); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9296#note_120746