Connor McAdams (@cmcadams) commented about dlls/setupapi/tests/devinst.c:
+ { + winetest_pop_context(); + continue; + } + /* However, setting this property to its existing value (if it has one) succeeds. */ + size = 0; + SetLastError(0xdeadbeef); + ret = pSetupDiGetDevicePropertyW(set, &device_data, key, &type, NULL, 0, &size, 0); + err = GetLastError(); + ok(!ret, "Expect failure.\n"); + if (err == ERROR_NOT_FOUND) + { + winetest_pop_context(); + continue; + } + ok(err == ERROR_INSUFFICIENT_BUFFER, "Expect last error %#x, got %#lx\n", ERROR_INSUFFICIENT_BUFFER, err); Is `ERROR_NOT_FOUND` returned consistently for a particular set of properties? If so, you should probably add a variable to `inbuilt_props` to specify what the expected error value is here, to make sure it is consistent and doesn't change in the future for a particular property.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109482