Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
+ enum vkd3d_tessellator_domain domain) { - if (kind < ARRAY_SIZE(sysval_semantic_table)) + if (kind == SEMANTIC_KIND_TESSFACTOR) + { + switch (domain) + { + case VKD3D_TESSELLATOR_DOMAIN_LINE: + return VKD3D_SHADER_SV_TESS_FACTOR_LINEDET; + case VKD3D_TESSELLATOR_DOMAIN_TRIANGLE: + return VKD3D_SHADER_SV_TESS_FACTOR_TRIEDGE; + case VKD3D_TESSELLATOR_DOMAIN_QUAD: + return VKD3D_SHADER_SV_TESS_FACTOR_QUADEDGE; + default: + FIXME("Unhandled domain %u.\n", domain); + return VKD3D_SHADER_SV_TESS_FACTOR_TRIEDGE; I know there is no agreement here, but my preference still is for validating the domain when parsing and then using `vkd3d_unreachable()` here.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/767#note_67285