On Tue Jul 12 18:45:48 2022 +0000, **** wrote:
Zebediah Figura replied on the mailing list: ``` On 7/12/22 13:01, Claire Girka wrote:
From: Claire Girka <claire(a)sitedethib.com>
Do not assume the underlying driver will return meaningful data, as it may not support BusQueryContainerID which will be queried in a next commit. --- dlls/ntoskrnl.exe/pnp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/ntoskrnl.exe/pnp.c b/dlls/ntoskrnl.exe/pnp.c index 71c03586897..69f15d82875 100644 --- a/dlls/ntoskrnl.exe/pnp.c +++ b/dlls/ntoskrnl.exe/pnp.c @@ -75,7 +75,7 @@ static struct wine_rb_tree device_interfaces = { interface_rb_compare }; static NTSTATUS get_device_id( DEVICE_OBJECT *device, BUS_QUERY_ID_TYPE type, WCHAR **id ) { IO_STACK_LOCATION *irpsp; - IO_STATUS_BLOCK irp_status; + IO_STATUS_BLOCK irp_status = { .Information = 0 }; KEVENT event; IRP *irp;
We never interpret Information if the IRP fails, so what's the point? _______________________________________________ wine-gitlab mailing list -- wine-gitlab(a)winehq.org To unsubscribe send an email to wine-gitlab-leave(a)winehq.org ``` No point, that was a misguided attempt at fixing the test failures that I thought were due to memory corruption. I have a better grasp of what is happening and will skip this change in the next patch set.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/432#note_4002