Re: [PATCH v3 0/3] MR773: vkd3d-shader/ir: Try harder to move `break's to the end of loops.

[Conor McCarthy (＠cmccarthy)]

Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
> if ((ret = vsir_cfg_synthesize_selections(cfg, loop_body)) < 0)
>              goto fail;
>
> -        if ((ret = vsir_cfg_append_loop(cfg, &new_list, loop)) < 0)
> +        if ((ret = vsir_cfg_append_loop(cfg, new_list, loop)) < 0)
>              goto fail;
>      }
>
> -    vsir_cfg_structure_list_cleanup(list);
> -    *list = new_list;
> -
> -    return VKD3D_OK;
> +    ret = VKD3D_OK;
>
> fail:

This is no longer only a failure path, so should probably be renamed for clarity.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/773#note_67673