Re: [PATCH v7 0/6] MR6640: propsys: Support converting to BSTR for PropVariantToVariant.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/propsys/propvar.c:
> HRESULT WINAPI PropVariantToBSTR(REFPROPVARIANT propvar, BSTR *bstr)
>  {
> -    FIXME("propvar %p, bstr %p.\n", propvar, bstr);
> +    WCHAR *str;
> +    HRESULT hr;
> +
> +    TRACE("propvar %p, propvar->vt %#x, bstr %p.\n",
> +            propvar, propvar ? propvar->vt : 0, bstr);
> +
> +    if (FAILED(hr = PropVariantToStringAlloc(propvar, &str)))
> +        return hr;
> +
> +    *bstr = SysAllocString(str);
> +    CoTaskMemFree(str);

You could check for allocation failure here too.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6640#note_86898