Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/tests/mfmediaengine.c:
+ + if (impl->sample) + { + hr = IMFSample_GetUINT32(impl->sample, &IID_IMFSample, &val); + if (impl->is_receiver) + { + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + ok(val == 42, "Got unexpexted value %u.\n", val); + } + else + { + ok(hr == MF_E_ATTRIBUTENOTFOUND, "Unexpected hr %#lx.\n", hr); + ok(val == 41, "Got unexpexted value %u.\n", val); + + IMFSample_SetUINT32(impl->sample, &IID_IMFSample, 42); + } Please remove second 'val' test, and fix a typo in its test message. Instead of 'is_receiver' I'd called it something like 'index', to make it clear which one comes first.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2778#note_37791