2 Apr
2024
2 Apr
'24
5:19 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/ir.c:
{ struct vsir_cfg cfg;
+ if ((result = vsir_program_materialize_phis_to_temps(program)) < 0) + return result;
This commit seems to be doing two different things: * generating MOV instead of MOVC when converting PHIs (which is sensible, I was overly conservative originally with MOVC); * splitting processing PHIs from processing all the other instructions. Could you please split these changes? For the first one something list [this patch](/uploads/c6874604d67a9e6492a8463c869944a5/patch.diff) should be enough. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/749#note_66644