12 Apr
2024
12 Apr
'24
11:36 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
src_param_init_from_value(&src_params[i], operands[i]); }
+static enum vkd3d_shader_register_type register_type_from_dxil_semantic_kind( + enum vkd3d_shader_sysval_semantic sysval_semantic) +{ + switch (sysval_semantic) + { + case VKD3D_SHADER_SV_DEPTH: + return VKD3DSPR_DEPTHOUT; + case VKD3D_SHADER_SV_DEPTH_GREATER_EQUAL: + return VKD3DSPR_DEPTHOUTGE; + case VKD3D_SHADER_SV_DEPTH_LESS_EQUAL: + return VKD3DSPR_DEPTHOUTLE; + default: + return VKD3DSPR_COUNT;
Maybe `VKD3DSPR_INVALID` is more appropriate here? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777#note_67715