Rémi Bernon (@rbernon) commented about dlls/windows.devices.geolocation.geolocator/main.c:
+ UINT32 len; + if (hstr && !((ULONG_PTR)hstr >> 16)) return "(invalid)"; + str = WindowsGetStringRawBuffer(hstr, &len); + return wine_dbgstr_wn(str, len); +} + +struct geolocator +{ + IActivationFactory IActivationFactory_iface; + LONG ref; +}; + +static inline struct geolocator *impl_from_IActivationFactory(IActivationFactory *iface) +{ + return CONTAINING_RECORD(iface, struct geolocator, IActivationFactory_iface); +} I'd prefer to see a consistent style between the tests and the implementation. Personally I prefer the style you used in the tests, which is used in several other WinRT modules.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3189#note_37253