26 Feb
2024
26 Feb
'24
12:22 p.m.
David Kahurani (@kahurani) commented about dlls/wbemprox/services.c:
+ free( key ); + free_path( path ); + return E_OUTOFMEMORY; + } + wcscpy( path->filter, key ); + memcpy( path->filter + len_key, p, len * sizeof(WCHAR) ); + path->filter_len = len + len_key; + path->filter[path->filter_len] = 0; + free( key ); + } + else if (p[0]) + { + free_path( path ); + return WBEM_E_INVALID_OBJECT_PATH; + } + This notably changes the behaviour of existing code without corresponding tests. Just noting, not being very familiar with wbemprox myself.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5160#note_62640