Re: [PATCH v4 0/6] MR8251: mshtml: Attribute node removal and misc fixes.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/htmlelem.c:
> return hres;
>  }
>
> +static HTMLDOMAttribute *find_attr_in_list(HTMLAttributeCollection *attrs, DISPID dispid, LONG *pos)
> +{
> +    HTMLDOMAttribute *iter, *ret = NULL;
> +    struct list *list = &attrs->attrs;
> +    unsigned i = 0;
> +
> +    LIST_FOR_EACH_ENTRY(iter, list, HTMLDOMAttribute, entry) {
> +        if(iter->dispid == dispid) {
> +            ret = iter;
> +            break;

There is no need for `ret` variable, you may just return here.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8251#note_110049