20 Sep
2024
20 Sep
'24
10:03 p.m.
Nikolay Sivov (@nsivov) commented about dlls/propsys/propvar.c:
HRESULT WINAPI PropVariantToVariant(const PROPVARIANT *propvar, VARIANT *var) { - return E_NOTIMPL; + HRESULT hr = S_OK; + + TRACE("propvar %p, var %p, propvar->vt %#x.\n", var, propvar, propvar->vt);
The order is wrong. Also, it shouldn't crash on null referencing when traces are enabled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6526#note_82903