12 Mar
2024
12 Mar
'24
4:10 a.m.
Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
size_t *loops_by_header;
struct vsir_block_list order; + struct cfg_loop_interval + { + /* `begin' is the position of the first block of the loop in + * the topological sort; `end' is the position of the first + * block after the loop. In other words, `begin' is where a + * `continue' instruction would jump and `end' is where a + * `break' instruction would jump. */ + unsigned int begin, end;
Is `begin` always the header block? If so, is `header` a better name? Similarly, if `end` is always the merge block, can we call it `merge`? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/698#note_64332