4 Jul
2024
4 Jul
'24
10:01 a.m.
Rémi Bernon (@rbernon) commented about dlls/windows.web/tests/web.c:
hr = IActivationFactory_QueryInterface( factory, &IID_IJsonObject, (void **)&json_object ); ok( hr == E_NOINTERFACE, "got hr %#lx.\n", hr );
+ hr = RoActivateInstance( str, &inspectable );
```suggestion:-0+0 hr = WindowsCreateString( json_object_name, wcslen( json_object_name ), &str ); ok( hr == S_OK, "got hr %#lx.\n", hr ); hr = RoActivateInstance( str, &inspectable ); ``` I'd suggest to keep the `WindowsDeleteString( str );` above and duplicate the string creation. Makes the cleanup easier to track (because right now you're leaking the string if the class isn't present). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5992#note_75111