Re: [PATCH v4 0/1] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_parser.c:
> +
> +static NTSTATUS wow64_wg_parser_push_data(void *args) {
> +    struct
> +    {
> +        wg_parser_t parser;
> +        PTR32 data;
> +        UINT32 size;
> +    } *params32 = args;
> +    struct wg_parser_push_data_params params = {
> +        params32->parser,
> +        ULongToPtr(params32->data),
> +        params32->size
> +    };
> +
> +    return wg_parser_push_data(¶ms);
> +}
static NTSTATUS wow64_wg_parser_push_data(void *args)
{
    struct
    {
        wg_parser_t parser;
        PTR32 data;
        UINT32 size;
    } *params32 = args;
    struct wg_parser_push_data_params params =
    {
        .parser = params32->parser,
        .data = ULongToPtr(params32->data),
        .size = params32->size,
    };

    return wg_parser_push_data(&params);
}

Same below for the braces placement. I also prefer using designated initializers for clarity (which also saves you the 0 initialization for *out* members), and trailing comma to avoid unnecessary line changes in the future, but that's really just a nitpick.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3075#note_35880