Re: [PATCH 0/1] MR4539: d3dx9_36: Use CRT allocation functions.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/effect.c:
> }
>      ret = effect->current_parameter_block;
>
> -    ret->buffer = heap_realloc(ret->buffer, ret->offset);
> +    ret->buffer = realloc(ret->buffer, ret->offset);

I guess I have to point out that this could fail, after mentioning the same in the d3drm MR :sweat_smile: 

Like there, you can assign the result to a different variable and update ret->buffer only when it's non-NULL.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4539#note_54558