Re: [PATCH v2 0/5] MR2778: mfmediaengine: Add support for video effects.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c:
> -    FIXME("%p, %p, %d stub.\n", iface, effect, is_optional);
> +    struct media_engine *engine = impl_from_IMFMediaEngineEx(iface);
> +    struct video_effect *tmp;
> +    HRESULT hr = S_OK;
>
> -    return E_NOTIMPL;
> +    TRACE("%p, %p, %d.\n", iface, effect, is_optional);
> +
> +    EnterCriticalSection(&engine->cs);
> +
> +    if (engine->flags & FLAGS_ENGINE_SHUT_DOWN)
> +        hr = MF_E_SHUTDOWN;
> +    else if (!(tmp = realloc(engine->effects.video_effects,
> +        sizeof(*engine->effects.video_effects) * (engine->effects.video_effects_size + 1))))
> +    {
> +        hr = MF_E_INVALIDREQUEST;
> Is that E_OUTOFMEMORY?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2778#note_34654