Re: [PATCH v2 0/1] MR10036: winemac.drv: Attempt to correct the size of icon resources.

[Tim Clem (＠tclem)]

On Thu Feb  5 21:03:25 2026 +0000, Alexandre Julliard wrote:
> Is that because we are passing the PNG bits through? I'm not sure why we
> do this, CreateIconFromResourceEx should be able to handle PNGs.
> Yes, for PNGs we pass the bits back to Unix for processing. Perhaps we do that because we ultimately need a CGImageRef, and we can skip the roundtripping from an HICON (create_cgimage_from_icon) if we know it's a png?

But yes, it does look like we could skip that and use CreateIconFromResourceEx universally. But even if we used CreateIconFromResourceEx, we'd still fault, just in PE rather than Unix, unless we correct the size.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10036#note_128906