8 Oct
2024
8 Oct
'24
7:44 a.m.
Looks ok. Could you re-order the commits so that the tests come first (with added `todo_wine`s on the tests that'll fail). Then follow with the implementation changes, removing `todo_wine`s as appropriate. That way it's clear that your changes do indeed fix the tests that you're claiming they do. Also, it's no long necessary to add `Signed-off-by` tags. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6608#note_84307