31 Jul
2023
31 Jul
'23
3:24 p.m.
Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/graphicspath.c:
GpPath* path;
GdipCreatePath(FillModeAlternate, &path); + status = GdipAddPathArc(path, 100.0, 100.0, 0.0, 0.0, 0.0, 90.0); + expect(InvalidParameter, status);
A couple of improvements I would suggest: 1. Separate into zero-width vs zero-height tests. 2. Test negative width/height as well, to see whether 0 is a special case (error on value != 0) vs a boundary (error on value <= 0). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3461#note_40831