28 Sep
2023
28 Sep
'23
3:16 p.m.
Jacek Caban (@jacek) commented about dlls/winemac.drv/dllmain.c:
static NTSTATUS WINAPI macdrv_app_icon(void *arg, ULONG size) { - struct app_icon_params *params = arg; - struct app_icon_result *result = param_ptr(params->result); + struct app_icon_result result; HRSRC res_info; - HGLOBAL res_data; + HGLOBAL res_data = NULL; GRPICONDIR *icon_dir; int i;
TRACE("()\n");
- result->count = 0; + if (size) + return NtCallbackReturn(NULL, 0, STATUS_INVALID_PARAMETER); You don't need to validate arguments from Unix side.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3974#note_47104